-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): refactor invite/invitations/accept/decline commands #188
Conversation
@@ -27,6 +27,7 @@ async function login(opts) { | |||
current.registries = current.registries || {}; | |||
current.registries[opts.registry] = current.registries[opts.registry] || {}; | |||
current.registries[opts.registry].token = token; | |||
current.registries[opts.registry].username = username; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently does nothing since the payload returned by profile.loginWeb
only contains a token
key. This should be extended in services/registry/handlers/auth.js
.
SO Chris just changed the API out from under you in PR #135. Specifically, namespace memberships are now under Update endpoints and I will land this! |
@ceejbot done! You may want to double check my routing but I believe that should do it. |
Thank you! |
@all-contributors add @superhawk610 for code |
I've put up a pull request to add @superhawk610! 🎉 |
@superhawk610 I'm seeing this on
Cool if I fix over here #234 ? |
@olingern oops, looks like I forgot to pass |
Description
This PR refactors the
invite
,invitations
,accept
, anddecline
commands as described in #95.ds invitations
into either packages or namespaces depending on presence of--packages
flag--namespace
flag tods invite
--package
flag tods invite
--namespace
tods accept
--package/--as
tods accept
--namespace
tods decline
--package/--as
tods decline
Additionally, it includes a couple of other small tweaks:
username
in addition totoken
when logging in viads login
ds help
if the provided command isn't foundNotes
Closes #95.