Dockerize new services #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacanger
commented
Jun 9, 2019
| @@ -0,0 +1,20 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| // Use Node http rather than installing curl | |||
There was a problem hiding this comment.
More copy-paste that can be addressed separately, #213
zacanger
commented
Jun 9, 2019
| #!/usr/bin/env node | ||
|
|
||
| // Use Node http rather than installing curl | ||
| // to reduce container size |
There was a problem hiding this comment.
More copy-paste that can be addressed separately, #213
zacanger
commented
Jun 9, 2019
| const server = boltzmann.make(router, myMiddles); | ||
| server.listen(process.env.PORT, '0.0.0.0'); | ||
| logger.info(`listening on port: ${process.env.PORT}`); | ||
| const main = () => { |
There was a problem hiding this comment.
More copy-paste that can be addressed separately, #213
Closed
ceejbot
reviewed
Jun 9, 2019
| @@ -1,10 +1,11 @@ | |||
| FROM mhart/alpine-node:12 | |||
| ARG SERVICE | |||
There was a problem hiding this comment.
Dockerfiles have a lot of syntax to them! Glad you are here working on this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #135, moving these changes out of #204 to keep that focused. Blocks #204.