-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test_problems.py #226
Comments
Hey, this sound like something a newbie like me can do. Please assign me this issue. |
Hi, Can I work on this issue? |
Hello, thanks for your interest in contributing to OpenQAOA! |
Thank you @vishal-ph, Since it's a good first issue I will like to try it alone. |
Hi @vishal-ph, can you check and confirm if I am using correct naming conventions for test files or not? |
@vishal-ph , I have moved all the tests into different files. Kindly heck my PR if it's ready for merge with dev branch or not. |
@vishal-ph any updates? |
@devilkiller-ag, I have added my comments on the PR itself |
@vishal-ph The path is |
@vishal-ph the hyphen in folder name 'openqaoa-core' is causing an import problem. Python import statemens follows standard naming conventions, where module names shoukd consist of letters, digits and underscores only. Can I rename it to 'openqaoa_core'? |
@Newtech66, no, the path is correct. You will need to look at the |
@devilkiller-ag, yes, you are right about the import name conventions. However, openqaoa-core is just the name of the module, the import statement still works with |
@vishal-ph Ok, so all the new files should live in the same path as |
@Newtech66 Yes, that's correct. Although eventually, we would want to put all the problem class tests in the |
Fixed in PR #254 |
Issue Description
Describe the solution you'd like:
src/openqaoa-core/tests/test_problems.py
into different files containing relevant tests for each problem class defined in OpenQAOAsrc/openqaoa-core/openqaoa_core/problems/
.Create a new folder in
test_problems
and create scripts consisting of specific tests corresponding to that problem class.For e.g. create
test_maximumcut.py
and put all tests corresponding to maximum_cut.py in this fileNOTE: Please branch out of
openqaoa/dev
and make the PR toopenqaoa/dev
The text was updated successfully, but these errors were encountered: