fix: Add asterisk to the list of valid value characters #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for wildcards when using the https://npmjs.org/package/debug module (e.g. `DEBUG=myLib:*`). Probably has other utilities too, of course.
|
I have a related issue. In my case, I need to set a variable from command line like |
| @@ -47,7 +47,7 @@ if (argv.c) { | |||
| } | |||
|
|
|||
| function validateCmdVariable (param) { | |||
| if (!param.match(/^\w+=[a-zA-Z0-9"=^!?%@_&\-/:;.]+$/)) { | |||
| if (!param.match(/^\w+=[a-zA-Z0-9"=^!?%@_&\-/:;.*]+$/)) { | |||
There was a problem hiding this comment.
Suggested change
| if (!param.match(/^\w+=[a-zA-Z0-9"=^!?%@_&\-/:;.*]+$/)) { | |
| if (!param.match(/^\w+=[a-zA-Z0-9"=^!?%@_&\-/:;.*\\]+$/)) { |
Is it possible to add backslash?
|
I'm a bit worried about security issues and I don't have a lot of time to investigate all these regex changes. Are you also using this on Windows? Because otherwise you can use #56 (comment) |
7 tasks
|
I've just tested this with #105 and it seems to work so that's why I closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case was to allows for wildcards with the debug module. E.g.
dotenv -v DEBUG=myLib:* node testMyLib.js.Probably has other utilities too, of course.
Going off of #65, I also forked the regexr pattern and added a new test: https://regexr.com/6rfhn