Workshop Manager update #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch all workshop items instead of only 50 Preview image is always loaded from user input Download preview image to memory instead of file Allow typing newline in input boxes Allow non-ASCII character input in title, description and change notes Group all image file browser filters into 1 filter Always check if preview and content exist Open Steam to file page on successful publish
samisalreadytaken
force-pushed
the
ez2/workshop_manager-patch
branch
3 times, most recently
from
e801fd3
to
af51bbe
Compare
1upD
approved these changes
Jan 28, 2023
There was a problem hiding this comment.
LGTM! I tested this out in-game and I was able to update a workshop addon. Text strings are working. There was an NPE crash when I did not have the localization strings - I intend to fix this myself in an upcoming PR which will enable JPEG decompression. For now, I would like to merge this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General fixes include:
All workshop items are now fetched instead of only 50.
Status of preview image is displayed as text ("no image"/"loading") instead of always showing a black box.
Preview image is dynamically loaded on each key press on its input box, allowing user to easily look through file versions, or paste from clipboard.
Preview image downloads were assumed to be jpeg because regardless of the file type uploaded, Steam re-encodes images as jpeg to display on web pages; however internally stored files are unchanged, so this jpeg assumption would cause png preview images to fail to load. Images are now downloaded to memory and file type is correctly read.
Published files list default sort is fixed.
Non-ASCII input on title, description and change notes is enabled.
Image filters in file browser are grouped up into one filter. This is also the same behaviour of L4D2 & HLVR workshop managers.
Existence of preview image and addon content is now checked before upload. This fixes the issue of creating empty UGC items with invalid parameters.
Workshop item page is opened in Steam on successful upload. L4D2 & HLVR workshop managers open it on an internet browser, but doing it in Steam makes more sense.
Added localisation support. You will need to add the strings to
entropyzero2_english.txtyourself: https://gist.github.com/samisalreadytaken/9fb86655a101e467c0c4cbc8b0008e69