Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certain soldiers staring at the player for potentially hundreds of seconds after Bad Cop says something #245

Conversation

Blixibon
Copy link
Collaborator

@Blixibon Blixibon commented Jan 6, 2024

This PR fixes an issue in which soldiers selected to respond to Bad Cop stare at the player for a time value which wasn't subtracted from the server clock. More specifically, they stare at the player for 3 seconds more than the value the server clock will be when Bad Cop stops speaking, rather than simply staring at the player for the amount of time Bad Cop is speaking plus 3 seconds. While additional look targets can still be assigned, the player look target remains in the background and always reemerges if its duration has not passed. This also prevents the regular idle/tactical look target code from running, as it requires the soldier to not have any active look targets. This not only prevents soldiers from looking at hints or other entities in the world, but it also prevents soldiers from looking at or sometimes even noticing enemies in combat, as they are dead-set on staring at Bad Cop.

This issue appears to have been present since late 2019, and it most likely went unnoticed because the usual number of soldiers in the player's squad made it more difficult to notice that one of them was constantly staring at you, and the fact that it exponentially increases with the server clock means that this will mainly become a problem during longer playthroughs, when you're less likely to look at each individual soldier and realize one of them has been staring at you for 4 years because you had the gall to say something.

@MesaBlack

This comment was marked as off-topic.

@1upD 1upD merged commit e4ccd7d into entropy-zero:ez2/mapbase Mar 7, 2024
5 checks passed
1upD pushed a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants