Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent name: babel-plugin-root-import #63

Closed
denysdovhan opened this issue Dec 23, 2016 · 10 comments
Closed

More consistent name: babel-plugin-root-import #63

denysdovhan opened this issue Dec 23, 2016 · 10 comments

Comments

@denysdovhan
Copy link

denysdovhan commented Dec 23, 2016

Hi! Thanks for awesome plugin!

Babel's docs say about Plugin/Preset Shorthands. Most of plugins works well with that shorthand notation, but babel-root-import do not, because of its name.

Why this plugin wasn't named in common convention? Don't you think it would be better to rename the plugin?

For example, we've got this issue brunch/brunch#1549 in Brunch. Of course, issue will be fixed by our efforts, but wouldn't it be easier for users not to write babel-root-import, but just root-import, every time they want to use your plugin?

@michaelzoidl
Copy link
Member

I developed this plugin a while ago where this kind of standard wasn't that popular.
But i see your idea and i think it would be a better naming..
I'm wondering which side-effects this would have if rename this repo.

And i've seen that the name is already taken on npm :/
https://github.com/andrelom/babel-plugin-root-import

@denysdovhan
Copy link
Author

@michaelzoidl you can contact @andrelom and resolve this problem together.

Actually, I had experience in renaming packages — that's not so hard. You can deprecate old package and leave a message with link to the new one.

@andrelom
Copy link

andrelom commented Jan 2, 2017

Hi!

I am willing to remove/rename (deprecate) my NPM package in favor of the current one. Just send the instructions and I'll do it as soon as possible.

Sorry for the inconvenience.

@denysdovhan
Copy link
Author

@andrelom you need to give @michaelzoidl an access to your package. Then just update corresponding package.json's fields and publish. Package with old plugin name should be deprecated.

P.S: I think it's better to bump major version with renaming a package.

@TimCabbage
Copy link
Contributor

Major version bumps should be done with breaking functionality. Unsure if this constitutes one but i don't think so.

@denysdovhan
Copy link
Author

@sivael correct! But let's keep in mind that these two plugins may work a little bit different. Make sure, that you don't break anything. Be careful.

From my experience, it was better to bump major.

@TimCabbage
Copy link
Contributor

Oh. Did not connect the two facts. Yes then it has to be done.
Thanks for clarifying.

@michaelzoidl
Copy link
Member

Ok guys, i'm back.. sorry for the 26 days waiting :S

@andrelom awesome, if you can remove your package from npm i will move this repo to an organisation, rename it and publish it on your version.

I will bump the version to v5, i also add a information part in the repo - and add a note to the old babel-root-import npm package that we changed the name

Again, thank you guys for contributing to this

@andrelom
Copy link

andrelom commented Jan 30, 2017

Hi @michaelzoidl, I added you as a contributor in the package, so you can publish the current package and deprecate the old one. I've tried deleting a package before, and after all, they ask to transfer the ownership to the NPM and depreciate the package. So I believe that is the easiest way to solve this.

@michaelzoidl
Copy link
Member

Ok, after a year waiting I did it.. really..
Okay so i moved everything to the organisation i'm working for and renamed the package, i also bumped the version to 5.0.0 and published everything with the new name on npm

I think i can close this ticket now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants