Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for brunch/brunch#1549. #45

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Fix for brunch/brunch#1549. #45

merged 1 commit into from
Dec 27, 2016

Conversation

denysdovhan
Copy link
Contributor

@denysdovhan denysdovhan commented Dec 23, 2016

Find plugins with names that do not match common convention.
For example: `babel-root-import`
@shvaikalesh
Copy link
Contributor

LGTM, very clean & appreciate the comment.
However, Travis is failing.

@denysdovhan
Copy link
Contributor Author

denysdovhan commented Dec 23, 2016

@shvaikalesh the cause of failed build is not correlated with this PR. The problem in single-var notation:

Expected:

var a = c.a;
var b = c.b;

But got actual:

"use strict";

var c = {};
var a = c.a,
    b = c.b;

I can open another PR with corresponding fix, if you don't mind.

@shvaikalesh
Copy link
Contributor

@denysdovhan Thanks for digging it up.

PR with corresponding fix

Please do.

@denysdovhan
Copy link
Contributor Author

Tests are fixed in #46. Build is greeen.

@paulmillr paulmillr merged commit ace2700 into babel:master Dec 27, 2016
@denysdovhan denysdovhan deleted the fix-brunch-1549 branch December 27, 2016 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants