Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift the 2 characters restriction #122

Merged
merged 1 commit into from
May 11, 2019
Merged

Lift the 2 characters restriction #122

merged 1 commit into from
May 11, 2019

Conversation

MichaelBitard
Copy link
Contributor

Hi,

I took over this PR: #116 because we need it, I hope you don't mind.

@MichaelBitard MichaelBitard changed the title Remove 2 characters restriction Lift the 2 characters restriction May 10, 2019
@MichaelBitard MichaelBitard mentioned this pull request May 10, 2019
Closed
@brigand
Copy link
Collaborator

brigand commented May 10, 2019 •
edited

Thanks for the PR.

Couldn't we just use .indexOf(rootPathPrefix) === 0 instead of the dependency and going through RegExp?

Edit: I realize I mentioned this package in the other PR, but I can't remember why.

@MichaelBitard
Copy link
Contributor Author

Wow, you are absolutely right!

@MichaelBitard
Copy link
Contributor Author

There, should be better

@brigand brigand merged commit 0d2e172 into entwicklerstube:master May 11, 2019
@MichaelBitard
Copy link
Contributor Author

Thanks!

@brigand
Copy link
Collaborator

brigand commented May 11, 2019

Appreciate you doing this. Published as 6.2.0

@brigand brigand mentioned this pull request May 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelBitard @brigand