Implement a Ctrl-C handler and modify the server to exit cleanly. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has the added benefit that logging off with 'x' actually disconnects the Telnet connection. One ctrl-c will trigger shutdown and hopefully stop the server. A second ctrl-c will forcibly kill the server if something doesn't shut down cleanly. Calls the `finrou` routine on all modules. Session logoffs also call the `huprou` routine, though we might want to see if it's more natural to call `stsrou` instead.
enusbaum
reviewed
Aug 16, 2020
…n 0 milliseconds for each take request, spamming heartbeats and wasting CPU.
enusbaum
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has the added benefit that logging off with 'x' actually disconnects
the Telnet connection.
One ctrl-c will trigger shutdown and hopefully stop the server. A second
ctrl-c will forcibly kill the server if something doesn't shut down
cleanly.
Calls the
finrouroutine on all modules. Session logoffs also callthe
huprouroutine, though we might want to see if it's more naturalto call
stsrouinstead.