Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cloud cost credentials leftovers #335

Closed
eranelbaz opened this issue Apr 14, 2022 · 7 comments
Closed

Fix Cloud cost credentials leftovers #335

eranelbaz opened this issue Apr 14, 2022 · 7 comments
Assignees
@samuel-br
Labels
enhancement New feature or request
Projects
Ongoing Issues

Comments

@eranelbaz
Copy link
Member

Since we want to unblock #307 we decided to make this refactor in another issue,
Let's try to refactor tests and DRY it out
@eranelbaz eranelbaz added the enhancement New feature or request label Apr 14, 2022
@eranelbaz eranelbaz added this to To do in Ongoing Issues via automation Apr 14, 2022
@yaronya
Copy link
Contributor

yaronya commented Apr 17, 2022

@eranelbaz @samuel-br also please add missing examples + integration tests for these resources & data resources

@yaronya yaronya mentioned this issue Apr 17, 2022
Merged
@yaronya yaronya changed the title Fix Cloud cost credentials tests Fix Cloud cost credentials leftovers Apr 17, 2022
@yaronya
Copy link
Contributor

yaronya commented Apr 17, 2022

Also, what about import?
@eranelbaz

@eranelbaz
Copy link
Member Author

Also, what about import? @eranelbaz

We need to fix / add import for all credentials, we got stuck on - #99

IDK if important

@TomerHeber
Copy link
Collaborator

@eranelbaz - I think import was added in #99 for AWS, Azure, and GCP.
If it covers all use-cases, can this issue be closed?

@eranelbaz
Copy link
Member Author

The idea here is to try and DRY the test cases since they are the same tests 3 times,
one for each cloud provider

@TomerHeber
Copy link
Collaborator

might be related to #394

@yaronya
Copy link
Contributor

yaronya commented May 29, 2022

Yes @TomerHeber
I'm closing it as it's fixed in #394

@yaronya yaronya closed this as completed May 29, 2022
Ongoing Issues automation moved this from To do to Done May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuel-br samuel-br

Labels
enhancement New feature or request
Projects
Ongoing Issues
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TomerHeber @yaronya @eranelbaz @samuel-br