Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor credentials and cost. #394

Closed
TomerHeber opened this issue May 26, 2022 · 1 comment
Closed

Refactor credentials and cost. #394

TomerHeber opened this issue May 26, 2022 · 1 comment
Assignees
@TomerHeber
Labels
chore work in progress
Projects
Ongoing Issues

Comments

@TomerHeber
Copy link
Collaborator

There are large parts of code that are duplicated between GCP, Azure and AWS. Also between credentials and cost credentials, and finally in the acceptance tests.
@TomerHeber TomerHeber self-assigned this May 26, 2022
@TomerHeber TomerHeber added this to To do in Ongoing Issues via automation May 26, 2022
@TomerHeber TomerHeber moved this from To do to In progress in Ongoing Issues May 26, 2022
This was referenced May 26, 2022
Closed
Merged
TomerHeber added a commit that referenced this issue May 29, 2022
@TomerHeber
Merge branch 'main' into chore-refactor-credentials-#394
5e9c4d2
This was referenced May 31, 2022
Merged
Merged
Merged
@TomerHeber TomerHeber mentioned this issue Jun 9, 2022
Merged
TomerHeber added a commit that referenced this issue Jun 12, 2022
@TomerHeber
Merge branch 'main' into chore-refactor-credentials-#394
f852426
TomerHeber added a commit that referenced this issue Jun 12, 2022
@TomerHeber
Merge branch 'main' into chore-refactor-credentials-#394
1c82b4d
@TomerHeber
Copy link
Collaborator Author

This is now done. Reviewing the last part (the credential test files). I don't see much benefit in refactoring it (each varies. no real common code).

@TomerHeber TomerHeber moved this from In progress to Done in Ongoing Issues Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomerHeber TomerHeber

Labels
chore work in progress
Projects
Ongoing Issues
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomerHeber