Add team resource

[RLRabinowitz]

Issue & Steps to Reproduce / Feature Request

Feature Request: Support team resource

Solution

Support team resource with two attributes: name and description.
Add tests

[eranelbaz]

what about tests for multiple teams with the same name?
api returns nothing for the id?
all the errors we should add t.Run for them

[eranelbaz]

why you need this instead of returning nil, err?
i mean if uuidErr is nil then we don't need to make another if why not just return? same for the else

[RLRabinowitz]

I don't understand what you mean. 🤙🏻

[RLRabinowitz]

what about tests for multiple teams with the same name?

You mean in import? We currently don't have tests for imports (doesn't seem like the current framework supports it)

api returns nothing for the id?

This is something we never addressed in our code. We could throw an error in such a case. Not sure it's that important though

all the errors we should add t.Run for them

The thing is that the tests aren't really unit tests. So testing those isn't nice (you need to mock exact amount of previous calls)

[eranelbaz]

@RLRabinowitz

I mean you are throwing errors such as could not update team: so lets assert we get them when the relevant error accour,
those are stuff we do look at template resource, configuration variable resource cloud credentials project assignment and more

The thing is that the tests aren't really unit tests. So testing those isn't nice (you need to mock exact amount of previous calls)

I pretty sure we do that, we have stuff like gomock.InOrder to handle those

[RLRabinowitz]

@eranelbaz I know we do that sometimes. I'm just not sure it's worth the effort

[RLRabinowitz]

Added tests for all but delete, because it's impossible with the flow (the error is outside of a step).
That just shows how bad this framework is for unit tests

[eranelbaz]

[RLRabinowitz]

TF provider - Support team resource