Feat: Assign teams a project resource #140
Conversation
…into feat-team-project-assignment � Conflicts: � env0/provider.go
| if payload.TeamId == "" { | ||
| return TeamProjectAssignment{}, errors.New("must specify team_id") | ||
| } | ||
| if payload.ProjectRole == "" || |
There was a problem hiding this comment.
just asking, payload.ProjectRole == "" is not enough?
There was a problem hiding this comment.
nope.. I tried that but since it's a string (typedef of a string) it could be any string.
| const dummyProjectRole = "Admin" | ||
| const dummyTeamId = "dummyTeamId" | ||
|
|
||
| var _ = Describe("TeamProjectAssignment", func() { |
There was a problem hiding this comment.
Where are the tests for your argument's validations? like missing field you have checked
There was a problem hiding this comment.
| Type: schema.TypeString, | ||
| Description: "id of the team", | ||
| Required: true, | ||
| ForceNew: true, |
There was a problem hiding this comment.
what ForceNew do?
do we need it?
There was a problem hiding this comment.
ForceNew indicates that any change in this field requires the resource to be destroyed and recreated.
https://www.terraform.io/docs/extend/schemas/schema-behaviors.html#forcenew
There was a problem hiding this comment.
in other words, we want to destroy the existing teamProjectAssignment when the teamId was changed.
| if assignment.Id == id { | ||
| d.Set("project_id", assignment.ProjectId) | ||
| d.Set("team_id", assignment.TeamId) | ||
| d.Set("role", assignment.ProjectRole) |
There was a problem hiding this comment.
should break after found?
There was a problem hiding this comment.
also, should we use SetId in this method?
There was a problem hiding this comment.
should
breakafter found?
yes 7992743
also, should we use
SetIdin this method?
nope, we already have it ( they are equal...)
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
empty output... we don't print anything
Co-authored-by: Raz Ben Simon <raz.bensimon@env0.com>
…to feat-team-project-assignment
Issue & Steps to Reproduce / Feature Request
Solution