Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team data and tests #142

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Add team data and tests #142

merged 5 commits into from
Sep 2, 2021

Conversation

RLRabinowitz
Copy link
Contributor

Issue & Steps to Reproduce / Feature Request

Feature request: Team data source

Solution

Add it + tests + integration

@RLRabinowitz RLRabinowitz requested a review from a team September 1, 2021 15:50
@RLRabinowitz RLRabinowitz self-assigned this Sep 1, 2021
@RLRabinowitz
Copy link
Contributor Author

@RLRabinowitz RLRabinowitz changed the title Add team resource and tests Add team data and tests Sep 1, 2021
Copy link
Member

@eranelbaz eranelbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good
please also generate the docs

Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Description: "the name of the team",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the descriptions to captinal letter in the start

@RLRabinowitz
Copy link
Contributor Author

@eranelbaz Done all in 88a9cd7

@RLRabinowitz RLRabinowitz requested review from eranelbaz and a team September 2, 2021 12:15
@eranelbaz eranelbaz merged commit 3a807db into main Sep 2, 2021
@eranelbaz eranelbaz deleted the feat-add-team-data branch September 2, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants