fix gitlab_project_id changes every apply #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronya
reviewed
Sep 19, 2021
| @@ -243,7 +243,6 @@ func resourceTemplateRead(ctx context.Context, d *schema.ResourceData, meta inte | |||
| d.Set("description", template.Description) | |||
| d.Set("github_installation_id", template.GithubInstallationId) | |||
| d.Set("token_id", template.TokenId) | |||
| d.Set("gitlab_project_id", template.GitlabProjectId) | |||
There was a problem hiding this comment.
Can we cover this with some test?
It feels like we aren't asserting that the value is set after create/update.
|
f9f9cd3 fixed broken test |
|
@razbensimon looks like something is still broken here |
razbensimon
force-pushed
the
fix-gitlab-project-id-changes
branch
from
3fbecee
to
7ae0d91
Compare
|
@yaronya please rereview |
yaronya
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
gitlab_project_idalways gets changed on TF apply.Solution
Setcall because this field doesn't exist on the blueprint