Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Project Policies Support to client #150

Merged
merged 14 commits into from
Oct 13, 2021

Conversation

bernot-dev
Copy link
Contributor

@bernot-dev bernot-dev commented Oct 7, 2021

Issue & Steps to Reproduce / Feature Request

Project policies support, partially resolves #149

Solution

  • Add Get Policy API to Go client
  • Add Update Policy API to Go client

@roni-frantchi roni-frantchi added this to In progress in Ongoing Issues via automation Oct 7, 2021
@bernot-dev bernot-dev marked this pull request as ready for review October 7, 2021 12:23
@bernot-dev bernot-dev changed the title Feat: Add Project Policies Support Feat: Add Project Policies Support to client Oct 7, 2021
@yaronya yaronya requested a review from a team October 11, 2021 19:07
@yaronya
Copy link
Contributor

yaronya commented Oct 11, 2021

@bernot-dev please make sure to tag the env0 - Team as reviewers so we'd get alerted 🙏

Copy link
Contributor

@yaronya yaronya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernot-dev Nicely done overall 👍
Left you some comments

client/policy.go Outdated Show resolved Hide resolved
client/policy.go Outdated Show resolved Hide resolved
client/policy.go Outdated Show resolved Hide resolved
client/client_test.go Outdated Show resolved Hide resolved
client/policy.go Outdated Show resolved Hide resolved
client/policy_test.go Outdated Show resolved Hide resolved
client/policy_test.go Outdated Show resolved Hide resolved
Ongoing Issues automation moved this from In progress to Review in progress Oct 11, 2021
@bernot-dev
Copy link
Contributor Author

@bernot-dev please make sure to tag the env0 - Team as reviewers so we'd get alerted pray

@yaronya Actually, it looks like I don't have permissions to add reviewers or tag env0 - Team.

Copy link
Contributor

@yaronya yaronya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernot-dev well done 👏
Approved but also left you one final suggestion 🙏

client/policy.go Outdated Show resolved Hide resolved
Ongoing Issues automation moved this from Review in progress to Reviewer approved Oct 12, 2021
@bernot-dev
Copy link
Contributor Author

@yaronya I don't actually have permission to merge, but this is ready to go.

@yaronya yaronya merged commit f1e32fb into env0:main Oct 13, 2021
Ongoing Issues automation moved this from Reviewer approved to Done Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add Project Policies support
3 participants