Update config var description docs #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2021 15:26
1 similar comment
omry-hay
reviewed
Nov 1, 2021
|
|
||
| ### Optional | ||
|
|
||
| - **description** (String) a description of the variables |
There was a problem hiding this comment.
Please add that we limit it to 255 chars
| @@ -34,10 +35,11 @@ resource "env0_configuration_variable" "drop_down" { | |||
| ### Required | |||
|
|
|||
| - **name** (String) name to give the configuration variable | |||
| - **value** (String) value for the configuration variable | |||
| - **value** (String, Sensitive) value for the configuration variable | |||
There was a problem hiding this comment.
What does it mean? a boolean variable? do you think it's clear enough?
There was a problem hiding this comment.
this is the value of the variable and it is sensitive, meaning it is string but you won't get the value
we just didn't update the docs apparently before
liranfarage89
approved these changes
Nov 1, 2021
liranfarage89
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Update description
Solution