Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Skip Redundant deployments typo #162

Merged
merged 4 commits into from
Nov 21, 2021

Conversation

liranfarage89
Copy link
Contributor

@liranfarage89 liranfarage89 commented Nov 18, 2021

Issue & Steps to Reproduce / Feature Request

Fixed SkipRedunantDeployments typo.

Solution

Fix it.

Update:

  • I've found that number_of_environments_total was commented out for some reason ( maybe was WIP during that time? )
    So I've put it back it and add it to the integration tests.
  • Added example too.

@liranfarage89
Copy link
Contributor Author

Copy link
Contributor

@omry-hay omry-hay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liranfarage89 - do we also need to update the docs?

@liranfarage89
Copy link
Contributor Author

liranfarage89 commented Nov 21, 2021

@omry-hay it depends on whether we want to add an example or not... the docs are ok, the typo was in the code rather than the params.
I can do it actually... it takes few minutes

@liranfarage89 liranfarage89 requested review from omry-hay and a team November 21, 2021 09:15
Copy link
Member

@eranelbaz eranelbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets up the version

@liranfarage89 liranfarage89 merged commit 5718ddf into main Nov 21, 2021
@liranfarage89 liranfarage89 deleted the fix-skip-redundant-deployments-typo branch November 21, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants