feat:Ability to choose default setting for Deployment Triggers for new Environments #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiliFaroEnv0
force-pushed
the
feat-Add-ability-to-set-default-CD-and-PR-plan-by-project-policy
branch
from
a0c5a54
to
029f93c
Compare
GiliFaroEnv0
force-pushed
the
feat-Add-ability-to-set-default-CD-and-PR-plan-by-project-policy
branch
from
a091d51
to
c070c4c
Compare
GiliFaroEnv0
changed the title
yaronya
reviewed
Nov 23, 2021
client/model.go
Outdated
| SkipApplyWhenPlanIsEmpty bool `json:"skipApplyWhenPlanIsEmpty"` | ||
| DisableDestroyEnvironments bool `json:"disableDestroyEnvironments"` | ||
| SkipRedundantDeployments bool `json:"skipRedundantDeployments"` | ||
| Id string `json:"id"` |
There was a problem hiding this comment.
We don't send the id on the project update payload, the id is a part of the path
client/model.go
Outdated
| SkipApplyWhenPlanIsEmpty bool `json:"skipApplyWhenPlanIsEmpty"` | ||
| DisableDestroyEnvironments bool `json:"disableDestroyEnvironments"` | ||
| SkipRedundantDeployments bool `json:"skipRedundantDeployments"` | ||
| UpdatedBy string `json:"updatedBy"` |
There was a problem hiding this comment.
Same here, this is a computed attribute and shouldn't be sent on payload...
env0/resource_project_policy.go
Outdated
| Type: schema.TypeBool, | ||
| Description: "Run Terraform Plan on Pull Requests for new environments targeting their branch default value", | ||
| Optional: true, | ||
| Default: false, |
There was a problem hiding this comment.
Since all other fields here don't have a default value setting, I think we should change it to either make all of them with default values, or none.
HeverFarber
approved these changes
Nov 24, 2021
Comment on lines
+24
to
+31
| - **continuous_deployment_default** (Boolean) Redeploy on every push to the git branch default value | ||
| - **disable_destroy_environments** (Boolean) Disallow destroying environment in the project | ||
| - **id** (String) id of the policy | ||
| - **include_cost_estimation** (Boolean) Enable cost estimation for the project | ||
| - **number_of_environments** (Number) Max number of environments a single user can have in this project, 0 indicates no limit | ||
| - **number_of_environments_total** (Number) Max number of environments in this project, 0 indicates no limit | ||
| - **requires_approval_default** (Boolean) Requires approval default value when creating a new environment in the project | ||
| - **run_pull_request_plan_default** (Boolean) Run Terraform Plan on Pull Requests for new environments targeting their branch default value |
There was a problem hiding this comment.
why they not near each other - both of them belong trigger policy.
Plus I think id should be the first one
Comment on lines
+41
to
+47
| - **continuous_deployment_default** (Boolean) Redeploy on every push to the git branch default value | ||
| - **disable_destroy_environments** (Boolean) Disallow destroying environment in the project | ||
| - **include_cost_estimation** (Boolean) Enable cost estimation for the project | ||
| - **number_of_environments** (Number) Max number of environments a single user can have in this project, 0 indicates no limit | ||
| - **number_of_environments_total** (Number) Max number of environments in this project, 0 indicates no limit | ||
| - **requires_approval_default** (Boolean) Requires approval default value when creating a new environment in the project | ||
| - **run_pull_request_plan_default** (Boolean) Run Terraform Plan on Pull Requests for new environments targeting their branch default value |
There was a problem hiding this comment.
same. write one near to other
HeverFarber
added
ready to merge
GiliFaroEnv0
deleted the
feat-Add-ability-to-set-default-CD-and-PR-plan-by-project-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…w Environments
Issue & Steps to Reproduce / Feature Request
Add ability to set default CD and PR plan by project policy
Solution
Add ability to set default CD and PR plan by project policy