Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment resource variables on create #176

Merged

Conversation

alonnoga
Copy link
Contributor

@alonnoga alonnoga commented Dec 8, 2021

Issue & Steps to Reproduce / Feature Request

For some reason when putting the variables in the deploy request doesn't take affect when creating an environment ( but it does work on deployment requests)
Fix: When creating an environment add configuration changes under the environment.

@alonnoga alonnoga requested a review from a team December 8, 2021 20:44
@alonnoga
Copy link
Contributor Author

alonnoga commented Dec 8, 2021

@alonnoga alonnoga self-assigned this Dec 8, 2021
Copy link
Contributor

@HeverFarber HeverFarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a test for it?

@HeverFarber HeverFarber added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 9, 2021
@alonnoga alonnoga merged commit 1e67637 into main Dec 9, 2021
@alonnoga alonnoga deleted the fix-environment-resource-create-configuration-changes branch December 9, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants