fest: Environment Resource - configuration variables read & delete #182
Conversation
GiliFaroEnv0
force-pushed
the
feat-configure-variables-read-and-delete
branch
from
f85670a
to
a8a97d7
Compare
| d.SetId(environment.Id) | ||
| setEnvironmentSchema(d, environment) | ||
| setEnvironmentSchema(d, environment, client.ConfigurationChanges{}) |
There was a problem hiding this comment.
Cursed language
Why no optional parameters?
damn you go
There was a problem hiding this comment.
hate this
also no Ternary Operator ?:
as for the integration tests will be added on a different ticket to unblock the QA PARTY 🎉
There was a problem hiding this comment.
Thats not a blocker, as those are terraform files we need to update
There was a problem hiding this comment.
update this file
https://github.com/env0/terraform-provider-env0/blob/main/tests/integration/012_environment/main.tf
add the configuration part for the resource to create it and also data to read it
then expose a output and you need to assert the output is as you expect using this file
https://github.com/env0/terraform-provider-env0/blob/main/tests/integration/012_environment/expected_outputs.json
really small part
There was a problem hiding this comment.
There was a problem hiding this comment.
Why not here?
thats really small change
There was a problem hiding this comment.
@eranelbaz its not tried alot but its not
since on deploying the scope of the configuration variable changes to DEPLOYMENT and we can’t search by this scope
There was a problem hiding this comment.
lets work this out in a next pr
GiliFaroEnv0
force-pushed
the
feat-configure-variables-read-and-delete
branch
from
7379180
to
4dc342f
Compare
Issue & Steps to Reproduce / Feature Request
Environment Resource - configuration variables read & delete
Solution
Added Read logic for configuration variables
Added delete and update logic for configuration variables