Fix: Add glob_pattern validation when cd/PrPlan enabled #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-glob-pattern-validation � Conflicts: � env0/resource_environment.go � env0/resource_environment_test.go
…use 'true' is needed for the API to enable 'custom glob'
…into fix-glob-pattern-validation
alonnoga
approved these changes
Dec 21, 2021
env0/resource_environment.go
Outdated
| Type: schema.TypeString, | ||
| Description: "redeploy on file filter pattern", | ||
| Optional: true, | ||
| Default: "", |
There was a problem hiding this comment.
this could be redundant (I think* that d.get always returns the false value of that type)
alonnoga
reviewed
Dec 21, 2021
Comment on lines
+402
to
+413
| func assertDeploymentTriggers(autoDeployByCustomGlob string, continuousDeployment bool, pullRequestPlanDeployments bool, autoDeployOnPathChangesOnly bool) diag.Diagnostics { | ||
| if autoDeployByCustomGlob != "" { | ||
| if (continuousDeployment == false) && | ||
| (pullRequestPlanDeployments == false) { | ||
| return diag.Errorf("run_plan_on_pull_requests or deploy_on_push must be enabled for auto_deploy_by_custom_glob") | ||
| } | ||
| if autoDeployOnPathChangesOnly == false { | ||
| return diag.Errorf("cannot set auto_deploy_by_custom_glob when auto_deploy_on_path_changes_only is disabled") | ||
| } | ||
| } | ||
| return nil | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Currently we don't validate that CD/PrPlan are enabled if the user set a custom_glob_pattern. By default, the
runOnAnyChangeis enabled, so that should be true unless the user configured a glob pattern.Solution
truefor the glob to take effect.