Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add HCL configuration variable type #195

Merged
merged 14 commits into from
Dec 28, 2021
Merged

Feat: Add HCL configuration variable type #195

merged 14 commits into from
Dec 28, 2021

Conversation

liranfarage89
Copy link
Contributor

@liranfarage89 liranfarage89 commented Dec 22, 2021 •
edited
Loading

Issue & Steps to Reproduce / Feature Request

  • We want to add support to hcl variables in env0 terraform provider

Solution

  • Add format attribute in in configuration resource & environment->configuration
  • Using Directives & Templates, the user should create a string representing the hcl format of the variables
  • Refactor Create & Update configuration variable params

@liranfarage89
Copy link
Contributor Author

Add support for HCL variables in the TF provider

@liranfarage89 liranfarage89 self-assigned this Dec 27, 2021
GiliFaroEnv0
GiliFaroEnv0 requested changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!|
BUT you need to add this to environment_resource also 🥇

@liranfarage89
1. added format to environment configuration variable.
5fb20c7 
2. refactor format.HCL
3. refactor hcl=true to format.
@liranfarage89 liranfarage89 requested a review from a team December 28, 2021 16:35
GiliFaroEnv0
GiliFaroEnv0 approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally its over!
Great job

@liranfarage89 liranfarage89 merged commit 2ad99bb into main Dec 28, 2021
@liranfarage89 liranfarage89 deleted the feat-add-hcl-config-value branch December 28, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiliFaroEnv0 GiliFaroEnv0 GiliFaroEnv0 approved these changes

Assignees

@liranfarage89 liranfarage89

Labels
pending final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liranfarage89 @GiliFaroEnv0