Feat: Adding JSON Format to configuration variables #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLRabinowitz
approved these changes
Jan 3, 2022
| if variable.Schema.Format == client.HCL { | ||
| d.Set("format", string(client.HCL)) | ||
| if variable.Schema.Format != "" { | ||
| d.Set("format", variable.Schema.Format) | ||
| } |
There was a problem hiding this comment.
Shouldn't this whole logic be duplicated to environment resource's configuration variables as well?
There was a problem hiding this comment.
@RLRabinowitz looks like it's already there...
terraform-provider-env0/env0/resource_environment.go
Lines 579 to 583 in 2ad99bb
liranfarage89
approved these changes
Jan 3, 2022
Comment on lines
+9
to
+15
| func ValidateConfigurationPropertySchema(val interface{}, key string) (warns []string, errs []error) { | ||
| value := val.(string) | ||
| if value != string(client.HCL) && value != string(client.Text) && value != string(client.JSON) { | ||
| errs = append(errs, fmt.Errorf("%q can be either \"HCL\", \"JSON\" or empty, got: %q", key, value)) | ||
| } | ||
| return | ||
| } |
Comment on lines
101
to
107
| var mockWithFormat = ConfigurationVariable{} | ||
| copier.Copy(&mockWithFormat, &mockConfigurationVariable) | ||
| mockWithFormat.Schema.Format = schemaFormat | ||
| requestWithFormat := GetExpectedRequest(mockWithFormat) | ||
|
|
||
| DoCreateRequest(mockWithFormat, requestWithFormat) | ||
|
|
There was a problem hiding this comment.
was not easy to follow here, maybe take requestWithFormat inside DoCreateRequest because they both use mockWithFormat?
There was a problem hiding this comment.
changed in 67d139d
LMK WDYT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Add support for JSON Format configuration variables
Solution
TEST_PATTERNoption when running provider tests, since those take like 10 minutes