-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: environment scheduling resource #208
Conversation
…eat-environment-scheduling-resource
…eat-environment-scheduling-resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looking good, just have other issues IMO
please also attach the issue you are resolving
generate docs
add examples
harness.go
?
data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just look at my suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look on @eranelbaz requests
…eat-environment-scheduling-resource � Conflicts: � env0/provider.go � go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
Issue & Steps to Reproduce / Feature Request
Add
resource_environment_scheduling
Resolves #194
Solution
☝️
Also changed the environment scheduling expression model to cope with empty values, hence turned it to a pointer