Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downstream trigger api client #211

Merged
merged 5 commits into from
Jan 20, 2022
Merged

downstream trigger api client #211

merged 5 commits into from
Jan 20, 2022

Conversation

eranelbaz
Copy link
Member

@eranelbaz eranelbaz commented Jan 20, 2022

Issue & Steps to Reproduce / Feature Request

add api client for #193

Solution

this pr is to add the api client
next pr will be the resource

moved all the const variables into the functions instead of global scope

@eranelbaz eranelbaz self-assigned this Jan 20, 2022
@eranelbaz eranelbaz added this to In progress in Ongoing Issues via automation Jan 20, 2022
@eranelbaz eranelbaz marked this pull request as ready for review January 20, 2022 15:50
@eranelbaz eranelbaz removed this from In progress in Ongoing Issues Jan 20, 2022
@eranelbaz eranelbaz marked this pull request as draft January 20, 2022 15:50
@eranelbaz eranelbaz requested a review from a team January 20, 2022 16:08
@eranelbaz eranelbaz marked this pull request as ready for review January 20, 2022 16:08
Copy link
Contributor

@RLRabinowitz RLRabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

client/api_client.go Outdated Show resolved Hide resolved
client/aws_credentials_test.go Show resolved Hide resolved
client/model.go Outdated Show resolved Hide resolved
@eranelbaz
Copy link
Member Author

81f6e73 fixed broken tests

@eranelbaz eranelbaz merged commit f4e846f into main Jan 20, 2022
@eranelbaz eranelbaz deleted the chore-downstream-env-api branch January 20, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants