Workflow trigger resource #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 20, 2022 17:48
…rraform-provider-env0 into feat-workflow-triggers
…rraform-provider-env0 into feat-workflow-triggers
added 8 commits
January 20, 2022 18:55
…into feat-workflow-triggers � Conflicts: � client/model.go � client/workflow_triggers.go
eranelbaz
commented
Jan 23, 2022
| WorkspaceName string `json:"WorkspaceName"` | ||
| ProjectId string `json:"ProjectId"` | ||
| LatestDeploymentLog DeploymentLog `json:"latestDeploymentLog"` | ||
| Id string `json:"id"` |
There was a problem hiding this comment.
as we talked on slack we only want to expose the id
eranelbaz
commented
Jan 23, 2022
Comment on lines
+50
to
+58
| if arrayOk { | ||
| arrayValueString := "" | ||
| for _, arrayValue := range arrayValues { | ||
| arrayValueString += "\"" + arrayValue + "\"," | ||
| } | ||
| arrayValueString = arrayValueString[:len(arrayValueString)-1] | ||
|
|
||
| hclFields += fmt.Sprintf("\n\t%s = [%s]", key, arrayValueString) | ||
| } |
There was a problem hiding this comment.
there was a problem where we took array and just wrapped that in "[value1,value2]"
but we need ["value1","value2"] so the HCL will be valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolved #193
Solution
note there are a lot of files for this PR, but it consists out of harness tests + docs
resourceanddataharness