Bug: environment resource configuration field is affected by global s… #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Apr 7, 2022
|
Couple of questions:
|
|
We talked. I was wrong about the API, it must receive For now, we'll go with this approach @TomerHeber as discussed, this only needs some tests |
TomerHeber
force-pushed
the
bug-environment-resource-global-scope-#318
branch
from
f564034
to
6209d6a
Compare
TomerHeber
force-pushed
the
bug-environment-resource-global-scope-#318
branch
2 times, most recently
from
68938a7
to
9b4dc34
Compare
TomerHeber
force-pushed
the
bug-environment-resource-global-scope-#318
branch
from
9b4dc34
to
0f0b2ba
Compare
TomerHeber
commented
Apr 10, 2022
| @@ -100,6 +100,18 @@ func (client *ApiClient) ConfigurationVariablesByScope(scope Scope, scopeId stri | |||
| if err != nil { | |||
| return []ConfigurationVariable{}, err | |||
| } | |||
|
|
|||
| if scope != ScopeGlobal { | |||
There was a problem hiding this comment.
@RLRabinowitz - decided to fix the issue here. This covers much more use-cases.
I hope it makes sense: I filter out the global scope if the requested scope isn't global.
TomerHeber
commented
Apr 10, 2022
| @@ -247,7 +263,7 @@ var _ = Describe("Configuration Variable", func() { | |||
|
|
|||
| Describe("ConfigurationVariablesByScope", func() { | |||
| var returnedVariables []ConfigurationVariable | |||
| mockVariables := []ConfigurationVariable{mockConfigurationVariable} | |||
| mockVariables := []ConfigurationVariable{mockConfigurationVariable, mockGlobalConfigurationVariable} | |||
There was a problem hiding this comment.
As discussed. Added the use-case to the unit tests.
|
Note: I was unable to get the acceptance test working due to timeout. |
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment resource configuration field is affected by global scope variables
Issue & Steps to Reproduce / Feature Request
fixes #318
Solution
In the environment resource: filter out any configuration that is not within the environment scope.