Feat: add support for agent settings #330
Conversation
| @@ -0,0 +1,11 @@ | |||
| resource "env0_project" "example" { | |||
There was a problem hiding this comment.
Note/Question:
Is there a way to test this in harness?
I don't believe I have a way to create agents. Open to suggestions.
At the moment there are no added integration tests.
There was a problem hiding this comment.
That wouldn't be ROI positive at the moment so I'd leave it without harness tests
| } | ||
|
|
||
| // Not really needed. But required by Terraform SDK - https://github.com/hashicorp/terraform-plugin-sdk/issues/541 | ||
| d.SetId("1") |
There was a problem hiding this comment.
Does that mean that a user cannot have more than a single data resource of agents in his TF code?
There was a problem hiding this comment.
@yaronya ,
I can make it random if preferred.
However, why would using "1" as the ID prevent it from being used in multiple places?
See this bug fix in the google provider:
https://github.com/hashicorp/terraform-provider-google/pull/7375/files
There was a problem hiding this comment.
However, why would using "1" as the ID prevent it from being used in multiple places?
I think that the id has to be unique across the TF state, isn't it?
Random is also not so great, but preferable than "1".
I'd try and see if we can get from the schema/context the resource name and set it based on it (since it has to be unique anyways on your TF stack).
WDYT?
See this bug fix in the google provider
The example you just sent has the id based on some dynamic parameters such as project id and zone id
There was a problem hiding this comment.
@yaronya - regardless wouldn't it potentially cause duplication of ID (the example I sent).
There was a problem hiding this comment.
@yaronya - regardless wouldn't it potentially cause duplication of ID (the example I sent).
@TomerHeber
Yes, I believe it may create such duplication, but that example has somewhat lower chance to do so as it depends on at least some parameters
I'm assuming it'd break stuff as the id has to be unique, but maybe I'm wrong.
| @@ -0,0 +1,11 @@ | |||
| resource "env0_project" "example" { | |||
There was a problem hiding this comment.
That wouldn't be ROI positive at the moment so I'd leave it without harness tests
github-actions
bot
added
the
ready to merge
Issue & Steps to Reproduce / Feature Request
resolves #316
Solution
Added API call.
Added data-agents source.
Added unit tests.
Added documentation.