Fix: changing variable scope #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ready to merge
yaronya
reviewed
Apr 17, 2022
| }, | ||
| "environment_id": { | ||
| Type: schema.TypeString, | ||
| Description: "create the variable under this environment, not globally", | ||
| Optional: true, | ||
| ConflictsWith: []string{"template_id", "project_id", "is_required", "is_read_only"}, | ||
| ForceNew: true, |
There was a problem hiding this comment.
Please also apply this to the type attribute of the schema. API doesn't support changing an existing variable's type
TomerHeber
force-pushed
the
fix-changing-variable-scope-#332
branch
from
c7d99bf
to
3a5c2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #332
Solution
Added ForceNew to project_id, template_id, and environment_id.