Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: upgrade to go version 1.18 #338

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Feat: upgrade to go version 1.18 #338

merged 2 commits into from
Apr 16, 2022

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #336

Solution

Located all the 1.16 locations and modified them to 1.18.
Ran: go mod tidy.
(Unrelated) Formatted some terraform file (terraform fmt).

@TomerHeber TomerHeber self-assigned this Apr 14, 2022
@TomerHeber
Copy link
Collaborator Author

@yaronya - there's a comment in the code // please change also in repo secrets. Do you know what's it about?

@yaronya
Copy link
Contributor

yaronya commented Apr 14, 2022

@yaronya - there's a comment in the code // please change also in repo secrets. Do you know what's it about?

@TomerHeber I think we used to fetch the version as a secret from GH (since that's the only way to share a common value between multiple GH actions) but we changed it back and only comment was left. You can ignore it probably.

TomerHeber
TomerHeber commented Apr 14, 2022
View reviewed changes
.github/workflows/ci.yml
@@ -36,7 +36,7 @@ jobs:
- name: Go staticcheck
uses: dominikh/staticcheck-action@v1.2.0
with:
version: "2021.1.2"
version: "2022.1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.18 requires a newer staticcheck.

@TomerHeber TomerHeber requested a review from yaronya April 14, 2022 13:47
razbensimon
razbensimon approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@razbensimon razbensimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Apr 16, 2022
@razbensimon
Copy link
Contributor

@yaronya - there's a comment in the code // please change also in repo secrets. Do you know what's it about?

@TomerHeber I think we used to fetch the version as a secret from GH (since that's the only way to share a common value between multiple GH actions) but we changed it back and only comment was left. You can ignore it probably.

So maybe let's remove that comment? @yaronya
@TomerHeber

@TomerHeber TomerHeber merged commit 9bc127a into main Apr 16, 2022
@TomerHeber TomerHeber deleted the feat-upgrade-go-version-#336 branch April 16, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razbensimon razbensimon razbensimon approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
dependency-change examples feature github-actions integration-tests ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to go version 1.18
3 participants
@TomerHeber @yaronya @razbensimon