Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add data source for templates #345

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #341

Solution

Added the new data source.
Added unit tests.
Added integration tests.
Added examples.

}

resource "env0_template" "github_template1" {
name = "Github Test-111"
Copy link
Contributor

@yaronya yaronya Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to set the name randomly (like we do in other tests) - relevant for below resources as well.
Otherwise the integration tests would fail on consecutive runs

Copy link
Collaborator Author

@TomerHeber TomerHeber Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point.... /:
I'll remove the output then. Can't it have it both ways I guess....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - fixed.

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Apr 28, 2022
@TomerHeber TomerHeber merged commit 12008eb into main Apr 28, 2022
@TomerHeber TomerHeber deleted the feat-add-datasource-for-templates-#341 branch April 28, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for templates
2 participants