Fix: env0_cost_credentials_project_assignment not working #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
May 9, 2022
| @@ -9,7 +9,9 @@ type CostCredentialProjectAssignment struct { | |||
| func (client *ApiClient) AssignCostCredentialsToProject(projectId string, credentialId string) (CostCredentialProjectAssignment, error) { | |||
| var result CostCredentialProjectAssignment | |||
|
|
|||
| err := client.http.Put("/costs/project/"+projectId+"/credentials", credentialId, &result) | |||
| err := client.http.Put("/costs/project/"+projectId+"/credentials", map[string]string{ | |||
There was a problem hiding this comment.
body passed was incorrect.
TomerHeber
commented
May 9, 2022
| @@ -22,7 +24,7 @@ func (client *ApiClient) RemoveCostCredentialsFromProject(projectId string, cred | |||
|
|
|||
| func (client *ApiClient) CostCredentialIdsInProject(projectId string) ([]CostCredentialProjectAssignment, error) { | |||
| var result []CostCredentialProjectAssignment | |||
| err := client.http.Get("/costs/project/"+projectId, nil, &result) | |||
| err := client.http.Get("/costs/project/"+projectId+"/credentials", nil, &result) | |||
There was a problem hiding this comment.
url path was incorrect.
TomerHeber
commented
May 9, 2022
| @@ -0,0 +1,23 @@ | |||
| provider "random" {} | |||
There was a problem hiding this comment.
Added an integration test to avoid issues moving forward.
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #366
Solution
The body argument was incorrect.
The URL path was incorrect.
Added an integration test.