Feat: add data source for getting a list of Cloud Credentials #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
May 12, 2022
| "credential_type": { | ||
| Type: schema.TypeString, | ||
| Description: "the type of cloud credential to filter by " + allowedCredentialTypesStr, | ||
| Optional: true, |
There was a problem hiding this comment.
setting to optional incases where someone (for some reason) wants to get all the credentials regardless of type.
yaronya
reviewed
May 12, 2022
Comment on lines
+4
to
+7
| required_providers { | ||
| env0 = { | ||
| source = "terraform-registry.env0.com/env0/env0" | ||
| } |
There was a problem hiding this comment.
Is this a new thing or am I wrong? I mean, shouldn't the integration tests use the local version and not the version from the public registry?
There was a problem hiding this comment.
yes. This is my bad.
There was a problem hiding this comment.
@yaronya - actually looking at it again. This is not new. All tests are like this.
I guess it's somehow working as expected...
There was a problem hiding this comment.
This is not the real registry (terraform-registry.env0.com doesn't exist).
This is set up in buildFakeTerraformRegistry in harness.go
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #358
Solution
Added the new data source.
Added acceptance tests.
Added integration tests.
Added example.