Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add random string to notification names to prevent name collision #379

Merged
merged 1 commit into from
May 16, 2022

Conversation

GiliFaroEnv0
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 commented May 16, 2022

Issue & Steps to Reproduce / Feature Request

when running the integration tests ALOT the destroy take some time or sometimes failed which causes a flaky for the next run

Solution

add a random string to notification names to prevent name collision

@GiliFaroEnv0 GiliFaroEnv0 self-assigned this May 16, 2022
@GiliFaroEnv0 GiliFaroEnv0 changed the title fix: add random string to notification names to prevent name collision Fix: add random string to notification names to prevent name collision May 16, 2022
@GiliFaroEnv0 GiliFaroEnv0 requested a review from a team May 16, 2022 13:01
@eranelbaz eranelbaz merged commit 0b32813 into main May 16, 2022
@eranelbaz eranelbaz deleted the fix-add-random-names-to-event branch May 16, 2022 13:10
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels May 16, 2022
@GiliFaroEnv0
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix integration-tests ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants