Fix: env0_gcp_credentials - apply after import will delete+create #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
May 16, 2022
| @@ -23,7 +26,7 @@ func TestUnitGcpCredentialsResource(t *testing.T) { | |||
| } | |||
|
|
|||
| updateGcpCredentialResource := map[string]interface{}{ | |||
| "name": "testUpdate", | |||
razbensimon
approved these changes
May 17, 2022
Comment on lines
+80
to
+82
| if err := writeResourceData(&credentials, d); err != nil { | ||
| return diag.Errorf("schema resource data serialization failed: %v", err) | ||
| } |
There was a problem hiding this comment.
Just asking, what changed that we now need it than before?
Is import flow will not work without it?
There was a problem hiding this comment.
The writeResourceData (and readReasourceData) is a utility function that reads all the fields in the interface and updates the schema via set calls.
This is future proof: in case you add more fields to the schema/api - no additional coding is needed (other than updating the schema).
There is a potential bug here that drifting is not detected (E.g., if someone changes the name in the UX). Once I added this code, it caught a bug in the tests as well (so I fixed the tests as well).
Import flow will work without it, and I just fixed bugs I encountered on the way.
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #99
The last part of the effort to add import to all credential types (Azure and AWS is complete).
Solution