Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: data env0_templates includes deleted templates #389

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix: data env0_templates includes deleted templates #389

merged 2 commits into from
May 24, 2022

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

fixes #350

Solution

  1. Added an if condition to filter out deleted templates.
  2. Uncommented integration test.
  3. Updated acceptance test.

@TomerHeber TomerHeber self-assigned this May 20, 2022
@TomerHeber TomerHeber requested a review from yaronya May 20, 2022 13:16
@TomerHeber
Copy link
Collaborator Author

@RLRabinowitz - it looks like tests are still flaky.
Is it possible it takes time for the API to mark templates as isDeleted, even after selection?

@yaronya yaronya removed their request for review May 22, 2022 09:40
RLRabinowitz
RLRabinowitz approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@RLRabinowitz RLRabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels May 24, 2022
@RLRabinowitz
Copy link
Contributor

@TomerHeber Can you please make sure the templates in 012 are using a dynamic name? So that this test wouldn't be flaky

@TomerHeber
Copy link
Collaborator Author

@TomerHeber Can you please make sure the templates in 012 are using a dynamic name? So that this test wouldn't be flaky

@RLRabinowitz - sure thing. I'll fix that.

@TomerHeber TomerHeber force-pushed the fix-includes-deleted-templates-#350 branch from ee5f114 to 0cd459a Compare May 24, 2022 15:35
@TomerHeber TomerHeber merged commit 888dd94 into main May 24, 2022
@TomerHeber TomerHeber deleted the fix-includes-deleted-templates-#350 branch May 24, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLRabinowitz RLRabinowitz RLRabinowitz approved these changes

Assignees

@TomerHeber TomerHeber

Labels
fix integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data env0_templates includes deleted templates
2 participants
@TomerHeber @RLRabinowitz