Feat: refactor resources/data to use the new serialization/deserializ… #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
force-pushed
the
feat-refactor-serialization-2-#376
branch
from
54587af
to
619ae43
Compare
TomerHeber
force-pushed
the
feat-refactor-serialization-2-#376
branch
from
619ae43
to
f83d23e
Compare
yaronya
approved these changes
May 22, 2022
| Type: schema.TypeString, | ||
| Description: "id of the project", | ||
| Required: true, | ||
| ValidateDiagFunc: ValidateNotEmptyString, |
There was a problem hiding this comment.
Do we really need to have this validation func when attribute is Required?
There was a problem hiding this comment.
So yeah... a weird thing...
It seems project_id = "" will path the required validation.
I was surprised as well...
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation logic
Solution
Some minor refactoring.
Part of a larger effort #376.