Feat: env0_environment resource support for PR plan / apply and Alias… #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
environments need to go through refactoring. |
TomerHeber
commented
May 23, 2022
| @@ -106,6 +107,7 @@ type EnvironmentCreate struct { | |||
| ConfigurationChanges *ConfigurationChanges `json:"configurationChanges,omitempty"` | |||
| TTL *TTL `json:"ttl,omitempty"` | |||
| TerragruntWorkingDirectory string `json:"terragruntWorkingDirectory,omitempty"` | |||
| VcsCommandsAlias string `json:"vcsCommandsAlias"` | |||
There was a problem hiding this comment.
omitempty not required. Empty string is considered "no alias".
yaronya
approved these changes
May 24, 2022
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… options
Issue & Steps to Reproduce / Feature Request
resolves #386
Solution
Added the field, updated create, read, update code, updated unit tests and integration tests.