Fix: project Data Source not outputting name/id properties #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
May 27, 2022
| @@ -19,12 +19,14 @@ func dataProject() *schema.Resource { | |||
| Description: "the name of the project", | |||
| Optional: true, | |||
| ExactlyOneOf: []string{"name", "id"}, | |||
| Computed: true, | |||
There was a problem hiding this comment.
Why would it fix the issue?
Strange...
output does work the second time running apply.
There was a problem hiding this comment.
I'm not sure but I wouldn't hold any thought on this one. Let's ship this out ASAP.
The provider framework is FAR from being great 😞
yaronya
approved these changes
May 29, 2022
| @@ -19,12 +19,14 @@ func dataProject() *schema.Resource { | |||
| Description: "the name of the project", | |||
| Optional: true, | |||
| ExactlyOneOf: []string{"name", "id"}, | |||
| Computed: true, | |||
There was a problem hiding this comment.
I'm not sure but I wouldn't hold any thought on this one. Let's ship this out ASAP.
The provider framework is FAR from being great 😞
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #229
Solution
It looks like adding computed "true" fixes the issue. Not sure why.
Ideas?