Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: env0_template import issue github_installation_id #406

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

closes #401

Solution

No bug.
Updated documentation and examples.

@@ -13,9 +13,9 @@ resource "env0_environment" "example" {
}

resource "env0_environment" "example_with_hcl_configuration" {
name = "environment with hcl"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terraform fmt...

Copy link
Contributor

@avnerenv0 avnerenv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but shouldn't the docs folder also be updated?
I mean - don't you need to run ./generate-docs.sh and only then commit push and merge?

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jun 2, 2022
@TomerHeber
Copy link
Collaborator Author

LGTM but shouldn't the docs folder also be updated? I mean - don't you need to run ./generate-docs.sh and only then commit push and merge?

@avnerenv0 - ./generate-docs.sh run automatically as part of the pipeline. It's not required to run it manually.

@avnerenv0
Copy link
Contributor

LGTM but shouldn't the docs folder also be updated? I mean - don't you need to run ./generate-docs.sh and only then commit push and merge?

@avnerenv0 - ./generate-docs.sh run automatically as part of the pipeline. It's not required to run it manually.

oh ok I understood differently from the README

@TomerHeber TomerHeber merged commit 26e99b9 into main Jun 2, 2022
@TomerHeber TomerHeber deleted the chore-github-installation-id-#401 branch June 2, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore examples provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env0_template import issue github_installation_id
2 participants