Chore: use generics in pagination #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
force-pushed
the
chore-use-generics-in-pagination-#415
branch
from
e177ac2
to
2987cf3
Compare
TomerHeber
commented
Jun 11, 2022
| timeout-minutes: 20 | ||
| steps: | ||
| - name: Install Go | ||
| run: apk add go |
There was a problem hiding this comment.
no need to install go - 1.18 is already installed as part of the docker image.
Before it would install go1.17.
TomerHeber
commented
Jun 11, 2022
| - name: Install Go | ||
| run: apk add go | ||
| - name: Install Terraform | ||
| run: apk add terraform |
There was a problem hiding this comment.
installing terraform instead...
TomerHeber
commented
Jun 11, 2022
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
noticed some depreciation warnings. Went away when switching to v3.
TomerHeber
commented
Jun 11, 2022
TomerHeber
commented
Jun 11, 2022
| type Paginated interface { | ||
| // FIXME: Environment | ||
| Environment |
There was a problem hiding this comment.
Adding back the generics in this file...
In case more paging is added in the future to other API calls. Generics will make it very simple to add support for.
TomerHeber
force-pushed
the
chore-use-generics-in-pagination-#415
branch
from
2987cf3
to
19ff58a
Compare
HeverFarber
approved these changes
Jun 12, 2022
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
closes #415
Solution
Harness was running in go1.17 because the terraform docker image was using golang 1.17.
Switched to using a go1.18 docker image and installed terraform via
apk.Making this change allows me to use generics (A new feature in go1.18).