Feat: environment resource does not support new templateless creation #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Jun 14, 2022
| "name": { | ||
| Type: schema.TypeString, | ||
| Description: "name to give the template", | ||
| Required: templateType == TemplateTypeShared, |
There was a problem hiding this comment.
varying behavior...
TomerHeber
commented
Jun 14, 2022
| Type: schema.TypeString, | ||
| Description: "description for the template", | ||
| Optional: true, | ||
| Computed: templateType == TemplateTypeSingle, |
There was a problem hiding this comment.
varying behavior...
TomerHeber
commented
Jun 14, 2022
| } | ||
|
|
||
| if templateType == TemplateTypeSingle { | ||
| s["id"] = &schema.Schema{ |
There was a problem hiding this comment.
varying behavior...
need to store the template id.
TomerHeber
changed the title
TomerHeber
force-pushed
the
feat-templateless-environment-#374
branch
from
d49c1b5
to
cc34ed3
Compare
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
This is a large/complex change. The feature will be divided into small PRs.
In this PR I've moved the template schema to a common function that receives template type (shared vs single).
part of #374