Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update configuration.environmentId docs #427

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

liranfarage89
Copy link
Contributor

Issue & Steps to Reproduce / Feature Request

resolves : #347

Since Zip doesn't use environment.configuration but only configuration with environment scope, a solution for using both is irrelevant.

There was a misunderstanding regarding their usage but eventually, we decided to update the docs by describing that using configuration.environment_id requires ignoring changes of environment.configuration

The issue with allowing both is that configuration requires an environment, so at the first run, the environment will be deployed without configuration variables. From the 2nd deployment, there will be a drift because the configuration resource metadata will be retrieved by the API of the environment.

In other words, those are 2 ways to manage the same resource so only one way should be picked. ( preferably the environment.configuration to prevent the first usage issue )

Solution

Add ignore changes requirement in configuration.environment_id description

@yaronya yaronya merged commit ee69ec3 into main Jun 21, 2022
@yaronya yaronya deleted the chore-update-docs-env-config branch June 21, 2022 15:54
@github-actions github-actions bot added the ready to merge PR approved - can be merged once the PR owner is ready label Jun 21, 2022
@liranfarage89
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env0_environment resource and env0_configuration_variable configuration block
2 participants