Feat: support newly added template types - pulumi, k8s & workflow #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomporat247
reviewed
Jun 26, 2022
env0/templates.go
Outdated
| "terragrunt", | ||
| "pulumi", | ||
| "k8s", | ||
| "complex", |
| @@ -502,7 +502,7 @@ func TestUnitTemplateResource(t *testing.T) { | |||
| "repository": template.Repository, | |||
| "type": "gruntyform", | |||
| }), | |||
| ExpectError: regexp.MustCompile(`must be one of: terragrunt, terraform`), | |||
| ExpectError: regexp.MustCompile(`must be one of`), | |||
There was a problem hiding this comment.
Does this work? shouldn't it list all of the available types
There was a problem hiding this comment.
It works. I didn't want us to modify the test every time a new type was added.
(This test isn't beneficial, to begin with).
Since it's a regex match, it passes because the prefix never changes.
tomporat247
approved these changes
Jun 26, 2022
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #425
Solution
Added the new types to the schema (resource and data) + documentation.