Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add new integrated vcs info to env0_environment data source #587

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #586

Solution

  1. Added data fields in environment schema.
  2. Updated acceptance tests.

@@ -58,6 +58,7 @@ type Template struct {
FileName string `json:"fileName,omitempty" tfschema:",omitempty"`
IsTerragruntRunAll bool `json:"isTerragruntRunAll"`
IsAzureDevOps bool `json:"isAzureDevOps" tfschema:"is_azure_devops"`
GitlabProjectId int `json:"gitlabProjectId,omitempty" tfschema:",omitempty"`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing from the API. It will need to be fixed in the backend.
Adding it... once fixed it will work properly.

return err
}

templateUpdater := struct {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating this struct allows me to use the writeResourceData.

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Feb 14, 2023
Copy link
Contributor

@eladmosh eladmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerHeber I approved your PR but we decided not to implement gitlab_project_id, can you please remove it from the env0_template data source and from env0_environment data source (that you added now)

@TomerHeber TomerHeber merged commit 026c3e5 into main Feb 14, 2023
@TomerHeber TomerHeber deleted the feat-vsc-environment-data-#586 branch February 14, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new integrated vcs info to env0_environment data source
2 participants