-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add new integrated vcs info to env0_environment data source #587
Conversation
client/template.go
Outdated
@@ -58,6 +58,7 @@ type Template struct { | |||
FileName string `json:"fileName,omitempty" tfschema:",omitempty"` | |||
IsTerragruntRunAll bool `json:"isTerragruntRunAll"` | |||
IsAzureDevOps bool `json:"isAzureDevOps" tfschema:"is_azure_devops"` | |||
GitlabProjectId int `json:"gitlabProjectId,omitempty" tfschema:",omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing from the API. It will need to be fixed in the backend.
Adding it... once fixed it will work properly.
return err | ||
} | ||
|
||
templateUpdater := struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creating this struct allows me to use the writeResourceData.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomerHeber I approved your PR but we decided not to implement gitlab_project_id
, can you please remove it from the env0_template
data source and from env0_environment
data source (that you added now)
Issue & Steps to Reproduce / Feature Request
resolves #586
Solution