Feat: support personal API keys #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Mar 3, 2023
| // The test was "randomly" added here to test organizationId failure (when there are multiple organizations). | ||
| // Ideally should be tested in organization. Unfortunatly, organizationId is private and cannot be tested directly. | ||
| // (test package name varies from package name). | ||
| Describe("Failure - Multiple Organizations", func() { |
There was a problem hiding this comment.
This is no longer true.
This is tested in the organization test.
TomerHeber
commented
Mar 3, 2023
| @@ -62,7 +89,7 @@ var _ = Describe("Organization", func() { | |||
|
|
|||
| _, err = apiClient.Organization() | |||
| Expect(err).ShouldNot(BeNil()) | |||
| Expect(err.Error()).Should(Equal("server responded with too many organizations")) | |||
| Expect(err.Error()).Should(Equal("the api key is not assigned to organization id: " + defaultOrganizationId)) | |||
There was a problem hiding this comment.
the way unit tests are built... I could only test this use case.
yaronya
approved these changes
Mar 7, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #608
Solution