Feat: add support for remote state access configuration #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarMalka
reviewed
Apr 9, 2023
client/remote_state_access.go
Outdated
|
|
||
| func (client *ApiClient) RemoteStateAccessConfigurationCreate(environmentId string, payload RemoteStateAccessConfigurationCreate) (*RemoteStateAccessConfiguration, error) { | ||
| var result RemoteStateAccessConfiguration | ||
| if err := client.http.Post("/remote-backend/states/"+environmentId+"/access-control", payload, &result); err != nil { |
TomerHeber
commented
Apr 9, 2023
| @@ -8,7 +8,7 @@ env: | |||
| ENV0_API_ENDPOINT: ${{ secrets.ENV0_API_ENDPOINT }} | |||
| ENV0_API_KEY: ${{ secrets.TF_PROVIDER_INTEGRATION_TEST_API_KEY }} # API Key for organization 'TF-provider-integration-tests' @ dev | |||
| ENV0_API_SECRET: ${{ secrets.TF_PROVIDER_INTEGRATION_TEST_API_SECRET }} | |||
| GO_VERSION: 1.18 | |||
| GO_VERSION: 1.19 | |||
There was a problem hiding this comment.
updated to golang 1.19.
updated to a newer staticcheck.
This was done to avoid deprecation warnings. (Unrelated to the PR).
github-actions
bot
added
ready to merge
ItamarMalka
dismissed
their stale review
After discussion on missing id on response gonna move to use the environmentId instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #628
Solution