Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add error property in latestDeploymentLog #643

Merged
merged 1 commit into from
May 1, 2023
Merged

Feat: add error property in latestDeploymentLog #643

merged 1 commit into from
May 1, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #641

Solution

Added Error field to the struct.

@TomerHeber TomerHeber requested a review from yaronya April 28, 2023 01:49
@TomerHeber TomerHeber self-assigned this Apr 28, 2023
sagilaufer1992
sagilaufer1992 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@sagilaufer1992 sagilaufer1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels May 1, 2023
@TomerHeber TomerHeber merged commit 5ea92eb into main May 1, 2023
6 checks passed
@TomerHeber TomerHeber deleted the feat-error-property-#641 branch May 1, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagilaufer1992 sagilaufer1992 sagilaufer1992 approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client feature ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Error property in latestDeploymentLog
2 participants
@TomerHeber @sagilaufer1992